[BUG] Metrics fixes (#2217) (#2218)

* updated release notes (#1997) * disable unfunctioning expand on metrics canvas --------- (cherry picked from commit 6edd8ef) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sumukh Swamy <[email protected]>
opensearch-project · Oct 19, 2024 · 20367b9 · 20367b9
1 parent a764143
commit 20367b9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 78 deletions.
diff --git a/...les/visualization_container/__tests__/__snapshots__/visualization_container.test.tsx.snap b/...les/visualization_container/__tests__/__snapshots__/visualization_container.test.tsx.snap
@@ -94,48 +94,6 @@ exports[`Visualization Container Component renders add visualization container 1
                   </EuiText>
                 </div>
               </EuiFlexItem>
-              <EuiFlexItem
-                className="visualization-action-button"
-                grow={false}
-              >
-                <div
-                  className="euiFlexItem euiFlexItem--flexGrowZero visualization-action-button"
-                >
-                  <EuiIcon
-                    data-test-subj="removeVisualizationButton"
-                    onClick={[Function]}
-                    type="crossInACircleFilled"
-                  >
-                    <EuiIconBeaker
-                      aria-hidden={true}
-                      className="euiIcon euiIcon--medium euiIcon-isLoading"
-                      data-test-subj="removeVisualizationButton"
-                      focusable="false"
-                      onClick={[Function]}
-                      role="img"
-                      style={null}
-                    >
-                      <svg
-                        aria-hidden={true}
-                        className="euiIcon euiIcon--medium euiIcon-isLoading"
-                        data-test-subj="removeVisualizationButton"
-                        focusable="false"
-                        height={16}
-                        onClick={[Function]}
-                        role="img"
-                        style={null}
-                        viewBox="0 0 16 16"
-                        width={16}
-                        xmlns="http://www.w3.org/2000/svg"
-                      >
-                        <path
-                          d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
-                        />
-                      </svg>
-                    </EuiIconBeaker>
-                  </EuiIcon>
-                </div>
-              </EuiFlexItem>
             </div>
           </EuiFlexGroup>
         </div>

diff --git a/...omponents/custom_panels/panel_modules/visualization_container/visualization_container.tsx b/...omponents/custom_panels/panel_modules/visualization_container/visualization_container.tsx
@@ -6,10 +6,8 @@
 import {
   EuiButton,
   EuiSmallButton,
-  EuiSmallButtonIcon,
   EuiCodeBlock,
   EuiContextMenuItem,
-  EuiContextMenuPanel,
   EuiFlexGroup,
   EuiFlexItem,
   EuiIcon,
@@ -20,7 +18,6 @@ import {
   EuiModalHeader,
   EuiModalHeaderTitle,
   EuiPanel,
-  EuiPopover,
   EuiSpacer,
   EuiText,
   EuiToolTip,
@@ -104,7 +101,6 @@ export const VisualizationContainer = ({
   onEditClick,
   cloneVisualization,
   showFlyout,
-  removeVisualization,
   catalogVisualization,
   inlineEditor,
   actionMenuType,
@@ -117,7 +113,6 @@ export const VisualizationContainer = ({
   const [visualizationData, setVisualizationData] = useState<Plotly.Data[]>([]);
   const [isLoading, setIsLoading] = useState(true);
   const [isError, setIsError] = useState({} as VizContainerError);
-  const onActionsMenuClick = () => setIsPopoverOpen((currPopoverOpen) => !currPopoverOpen);
   const closeActionsMenu = () => setIsPopoverOpen(false);
   const { http, pplService } = coreRefs;
   const { setToast } = useToast();
@@ -374,37 +369,6 @@ export const VisualizationContainer = ({
                 </EuiToolTip>
               </EuiText>
             </EuiFlexItem>
-            <EuiFlexItem grow={false} className="visualization-action-button">
-              {editMode ? (
-                <EuiIcon
-                  data-test-subj="removeVisualizationButton"
-                  type="crossInACircleFilled"
-                  onClick={() => {
-                    removeVisualization(visualizationId);
-                  }}
-                />
-              ) : (
-                <EuiPopover
-                  button={
-                    <EuiSmallButtonIcon
-                      aria-label="actionMenuButton"
-                      iconType="boxesHorizontal"
-                      onClick={onActionsMenuClick}
-                    />
-                  }
-                  isOpen={isPopoverOpen}
-                  closePopover={closeActionsMenu}
-                  anchorPosition="downLeft"
-                  panelPaddingSize="none"
-                >
-                  <EuiContextMenuPanel
-                    items={popoverPanel}
-                    data-test-subj="panelViz__popoverPanel"
-                    size="s"
-                  />
-                </EuiPopover>
-              )}
-            </EuiFlexItem>
           </EuiFlexGroup>
           {inlineEditor}
         </div>