Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in recipient #287

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix typo in recipient #287

merged 2 commits into from
Oct 23, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 17, 2024

Description

Found this typo while using playgrounds. Updated text from recepient to recipient.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024

@riysaxen-amzn @AWSHurneyt Can one of you review this PR as well?

Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yuye-aws yuye-aws merged commit 1772628 into opensearch-project:main Oct 23, 2024
11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-287-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1772628e63a56507e3f19c1fb250a16e9507a1e4
# Push it to GitHub
git push --set-upstream origin backport/backport-287-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-287-to-2.x.

@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024

I'll create a manual backport

cwperks added a commit to cwperks/dashboards-notifications that referenced this pull request Oct 23, 2024
* Fix typo in recipient

Signed-off-by: Craig Perkins <[email protected]>

* Set java-version to 21 on main

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 1772628)
@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024

Created manual backport: #289

AWSHurneyt pushed a commit that referenced this pull request Oct 23, 2024
* Fix typo in recipient (#287)

* Fix typo in recipient

Signed-off-by: Craig Perkins <[email protected]>

* Set java-version to 21 on main

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 1772628)

* Change to 11

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants