Skip to content

Commit

Permalink
Replace all wrong Chime urls with correct ones (#144) (#146)
Browse files Browse the repository at this point in the history
(cherry picked from commit a112f08)

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent c2b77b6 commit 9559b3a
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .cypress/fixtures/test_chime_channel.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"config_type": "chime",
"is_enabled": true,
"chime": {
"url": "https://sample-chime-webhook"
"url": "https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456"
}
}
}
2 changes: 1 addition & 1 deletion .cypress/integration/channels.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('Test create channels', () => {
cy.wait(delay);

cy.get('[data-test-subj="create-channel-chime-webhook-input"]').type(
'https://sample-chime-webhook'
'https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456'
);
cy.wait(delay);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ exports[`<ChannelSettingsDetails /> spec renders Chime channel 1`] = `
<dd
class="euiDescriptionList__description"
>
https://chimehook
https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456
</dd>
</dl>
</div>
Expand Down Expand Up @@ -238,7 +238,7 @@ exports[`<ChannelSettingsDetails /> spec renders Teams channel 1`] = `
<dd
class="euiDescriptionList__description"
>
https://chimehook
https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456
</dd>
</dl>
</div>
Expand Down
4 changes: 2 additions & 2 deletions public/pages/CreateChannel/__tests__/ChimeSettings.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ describe('<ChimeSettings /> spec', () => {
</CreateChannelContext.Provider>
);
const input = utils.getByLabelText('Webhook URL');
fireEvent.change(input, { target: { value: 'https://test-chime-url' } });
fireEvent.change(input, { target: { value: 'https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456' } });
fireEvent.blur(input);
expect(setChimeWebhook).toBeCalledWith('https://test-chime-url');
expect(setChimeWebhook).toBeCalledWith('https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456');
expect(setInputErrors).toBeCalled();
});
});
4 changes: 2 additions & 2 deletions test/mocks/mockData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const mockChime: ChannelItemType = {
config_type: 'chime',
is_enabled: true,
chime: {
url: 'https://chimehook',
url: 'https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456',
},
config_id: 'test-chime',
created_time_ms: 1622670451891,
Expand Down Expand Up @@ -166,7 +166,7 @@ const mockMicrosoftTeams: ChannelItemType = {
config_type: 'microsoft_teams',
is_enabled: false,
microsoft_teams: {
url: 'https://chimehook',
url: 'https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456',
},
config_id: 'test-slack',
created_time_ms: 1622670451891,
Expand Down

0 comments on commit 9559b3a

Please sign in to comment.