Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.18] Downgrade version to 2.18.0 for ser/de of new parameters of RequestRequest #16477

Open
wants to merge 1 commit into
base: 2.18
Choose a base branch
from
Open

[Backport 2.18] Downgrade version to 2.18.0 for ser/de of new parameters of RequestRequest #16477

wants to merge 1 commit into from
+4 −6

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 936cdb9 from #16472.

@github-actions
Change to correct version since this has been backported (#16472)
6c8e83d 
Signed-off-by: Spencer G. Jones <[email protected]>
(cherry picked from commit 936cdb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
dbwiddis approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. In 2.18.0 these are precisely the same value but if we need to bump the 2.18 branch to version 2.18.1 this would be needed for BWC.

It's OK to wait until 2.18.1 version bump on this branch to merge, though.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6c8e83d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 6c8e83d: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (d27ee4e) to head (6c8e83d).

Files with missing lines Patch % Lines
...ster/snapshots/restore/RestoreSnapshotRequest.java 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               2.18   #16477   +/-   ##
=========================================
  Coverage     71.83%   71.83%           
+ Complexity    65381    65343   -38     
=========================================
  Files          5312     5312           
  Lines        304995   304995           
  Branches      44440    44440           
=========================================
+ Hits         219090   219104   +14     
+ Misses        67614    67608    -6     
+ Partials      18291    18283    -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Oct 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwiddis @owaiskazi19