Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests in SnapshotStatusApisIT #16146

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Oct 1, 2024

Description

The following two tests started failing repeatedly from 8/27 to 9/4 and stopped afterwards

  • org.opensearch.snapshots.SnapshotStatusApisIT.testStatusAPICallForShallowCopySnapshot
  • org.opensearch.snapshots.SnapshotStatusApisIT.testExceptionOnMissingShardLevelSnapBlob

Dashboard

Both the tests failed with SnapshotMissingException. The failures were likely due to commits yet to be merged as part of Snapshot Scaling (#15084). As a preventive measure, we have used assertBusy and ran the test class locally for over 4.5K runs without any failures.

Related Issues

Resolves #15815

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lakshya Taragi <[email protected]>
@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for 8ad0555: SUCCESS

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.88%. Comparing base (d131d58) to head (8ad0555).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16146      +/-   ##
============================================
- Coverage     71.89%   71.88%   -0.01%     
+ Complexity    64466    64457       -9     
============================================
  Files          5288     5288              
  Lines        301439   301439              
  Branches      43552    43552              
============================================
- Hits         216706   216700       -6     
- Misses        66931    66995      +64     
+ Partials      17802    17744      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 43e7597 into opensearch-project:main Oct 1, 2024
62 of 63 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 1, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 43e7597)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Oct 1, 2024
(cherry picked from commit 43e7597)

Signed-off-by: Lakshya Taragi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hainenber pushed a commit to hainenber/OpenSearch that referenced this pull request Oct 1, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.x Backport to 2.x branch flaky-test Random test failure that succeeds on second run skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for SnapshotStatusApisIT
2 participants