Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BWC fix - correcting shard routing version #15554

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Sep 1, 2024

Description

Suspecting that BWC test failures are because of this version check, testing it

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for bc70c48: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❕ Gradle check result for bc70c48: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.81%. Comparing base (579f2aa) to head (bc70c48).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15554      +/-   ##
============================================
- Coverage     71.96%   71.81%   -0.15%     
+ Complexity    63654    63594      -60     
============================================
  Files          5247     5248       +1     
  Lines        297352   297416      +64     
  Branches      42981    42984       +3     
============================================
- Hits         213982   213598     -384     
- Misses        65774    66302     +528     
+ Partials      17596    17516      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 71d122b into opensearch-project:main Sep 1, 2024
62 of 63 checks passed
@mch2
Copy link
Member

mch2 commented Sep 2, 2024

Sorry about that forgot to update after the backport. Thanks @bharath-techie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants