Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add minTranslogGeneration to remote translog metadata filename #15489

Merged

Conversation

sachinpkale
Copy link
Member

Description

  • Currently, remote translog metadata file has following format:
    metadata__<inverted primary term>__<inverted tranlog generation>__<inverted creation timestamp>__nodeId__<metadata version>
  • Although this works for ordering metadata files in reverse chronological order, just by looking at the metadata file name, it does not provide info on min generation referred.
  • To make debugging easy, in this PR, we are adding min translog generation as part of remote translog metadata.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sachinpkale sachinpkale changed the title Add minTranslogGeneration to remote translog metadata filename [Remote Store] Add minTranslogGeneration to remote translog metadata filename Aug 29, 2024
Copy link
Contributor

✅ Gradle check result for c578228: SUCCESS

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (acee2ae) to head (c578228).
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15489      +/-   ##
============================================
- Coverage     71.87%   71.79%   -0.08%     
+ Complexity    63318    63238      -80     
============================================
  Files          5231     5233       +2     
  Lines        296521   296522       +1     
  Branches      42832    42827       -5     
============================================
- Hits         213113   212884     -229     
- Misses        65948    66129     +181     
- Partials      17460    17509      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 2b84305 into opensearch-project:main Aug 29, 2024
58 of 65 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Aug 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 31, 2024
Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
(cherry picked from commit 2b84305)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Aug 31, 2024
… (#15551)

(cherry picked from commit 2b84305)

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sachin Kale <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants