fix: fixed unsupported language issue due to cached language in localStorage #8674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Storage The issue: If selecting `PPL` in discover, and navigate to visualization creating page which doesn't support `PPL`, the `PPL` is still be used. The fix: It will only use the cached language selection from localStorage if the current app supports the language. Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8674 +/- ##
==========================================
- Coverage 60.86% 60.85% -0.01%
==========================================
Files 3793 3793
Lines 90381 90387 +6
Branches 14185 14186 +1
==========================================
Hits 55006 55006
- Misses 31898 31903 +5
- Partials 3477 3478 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Oct 22, 2024
Hailong-am
approved these changes
Oct 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
…Storage (#8674) * fix: fixed unsupported language issue due to cached language in localStorage The issue: If selecting `PPL` in discover, and navigate to visualization creating page which doesn't support `PPL`, the `PPL` is still be used. The fix: It will only use the cached language selection from localStorage if the current app supports the language. Signed-off-by: Yulong Ruan <[email protected]> * Changeset file for PR #8674 created/updated --------- Signed-off-by: Yulong Ruan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e94cf0c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Oct 23, 2024
…Storage (#8674) (#8678) * fix: fixed unsupported language issue due to cached language in localStorage The issue: If selecting `PPL` in discover, and navigate to visualization creating page which doesn't support `PPL`, the `PPL` is still be used. The fix: It will only use the cached language selection from localStorage if the current app supports the language. * Changeset file for PR #8674 created/updated --------- (cherry picked from commit e94cf0c) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
The issue happens when for example PPL is selected in discover, then navigate to visualization create page, a warning toast is displayed, see screenshot.
When saving the visualization, the
language: "PPL"is stored, though the current UI shows DQL is used, see screenshotThe fix:
It will only use the cached language selection from localStorage if the current app supports the language.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration