-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual backport 2.x] [Discover]Sample Queries and Saved Queries in No Results Page #8616 #8663
[Manual backport 2.x] [Discover]Sample Queries and Saved Queries in No Results Page #8616 #8663
Conversation
* Update Discover appearance Signed-off-by: Miki <[email protected]> * Changeset file for PR opensearch-project#8651 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 17103ba) Signed-off-by: Miki <[email protected]>
…election in Discover View (opensearch-project#8613) * Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View This PR primarily addresses the scenario when no index patterns (general) is available in the Discover view. Instead of redirecting users to the index management page, it introduces a new "No Index Patterns" panel. This panel provides users with the option to open a data selector and add index patterns directly from the Discover view, improving the user experience for new or empty deployments. To achieve, we move the selectedDataset state from ConnectedDatasetSelector to the app container's state management. This allows the AdvancedSelector, opened from the AppContainer, to update the dataset state effectively. Key changes include: * Implementing NoIndexPatternsPanel and AdvancedSelector components. * Refactoring dataset state management in AppContainer and Sidebar. * Modifying DiscoverCanvas to conditionally render NoIndexPatternsPanel. * Updating ConnectedDatasetSelector to use shared state and dataset change handling. Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> * Update design of no data selected Signed-off-by: Miki <[email protected]> * use i18n Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> * fix comments Signed-off-by: Anan Zhuang <[email protected]> * Update design of no data selected Signed-off-by: Miki <[email protected]> * fix lint error Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit 6659139) Signed-off-by: Miki <[email protected]>
…arch-project#8616) * Sample Queries and Saved Queries in No Results Page Signed-off-by: Sean Li <[email protected]> Signed-off-by: Miki <[email protected]> * Changeset file for PR opensearch-project#8616 created/updated * Update styling Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> (cherry picked from commit 9da1b77)
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8663 +/- ##
==========================================
- Coverage 60.95% 60.89% -0.06%
==========================================
Files 3786 3787 +1
Lines 90212 90316 +104
Branches 14126 14157 +31
==========================================
+ Hits 54988 55000 +12
- Misses 31758 31848 +90
- Partials 3466 3468 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Manually backported to 2.x with #8670 |
…ies in No Results Page opensearch-project#8616 (opensearch-project#8663)" This reverts commit 74a69d6.
Cherry-picked commit 17103ba from #8651
Cherry-picked commit 6659139 from #8613
Cherry-picked commit 9da1b77 from #8616