Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Move DatasetSelector from data plugin queryString comp to DataExplorer #8639

Closed
wants to merge 1 commit into from

Move DatasetSelector from data plugin queryString comp to DataExplore…

98a13f2
Select commit
Loading
Failed to load commit list.
Closed

[Backport 2.x] Move DatasetSelector from data plugin queryString comp to DataExplorer #8639

Move DatasetSelector from data plugin queryString comp to DataExplore…
98a13f2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 1s

60.94% (-0.01%) compared to e4133db

View this Pull Request on Codecov

60.94% (-0.01%) compared to e4133db

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (e4133db) to head (98a13f2).

Files with missing lines Patch % Lines
.../data_explorer/public/components/sidebar/index.tsx 25.00% 2 Missing and 1 partial ⚠️
.../plugins/data/public/ui/dataset_selector/index.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8639      +/-   ##
==========================================
- Coverage   60.94%   60.94%   -0.01%     
==========================================
  Files        3784     3784              
  Lines       90144    90152       +8     
  Branches    14113    14114       +1     
==========================================
+ Hits        54937    54941       +4     
- Misses      31750    31753       +3     
- Partials     3457     3458       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.