Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(worker): use internal helper client to GET pypi package data #44

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ba11b0y
Copy link
Contributor

@ba11b0y ba11b0y commented Mar 6, 2023

  • Uses the internal helper client to do a GET request to fetch pypi package data.
  • This makes it easier to later mock external HTTP calls

cc: @nishakm

Copy link
Contributor

@nishakm nishakm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks again for submitting small changes :).

One problem is that your commit message doesn't have the information you put in the PR comment. You can edit your commit message by running git commit --amend -s and then do git push -f to your fork.

var (
errorPypiCouldNotFetchPkgData = errors.New("could not fetch package data from PyPI")
const (
pypiBaseURL = "https://pypi.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, organizations mirror pypi.org internally (for example: https://www.jfrog.com/confluence/display/JFROG/PyPI+Repositories). Perhaps there is a way to configure this in a file and read that information in?

@ba11b0y
Copy link
Contributor Author

ba11b0y commented Mar 8, 2023

@nishakm Do you want me to put this on hold until I experiment around with finding how we can fetch as much from the local filesystem?

@nishakm
Copy link
Contributor

nishakm commented Mar 14, 2023

@nishakm Do you want me to put this on hold until I experiment around with finding how we can fetch as much from the local filesystem?

Yes, please. You can convert this PR into a draft for now.

@ba11b0y ba11b0y marked this pull request as draft March 14, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants