Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for adding JavaType marker after parsing XML #4595

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Laurens-W
Copy link
Contributor

@Laurens-W Laurens-W commented Oct 21, 2024

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@knutwannheden @timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added the enhancement New feature or request label Oct 21, 2024
@Laurens-W Laurens-W self-assigned this Oct 21, 2024

@Value
@With
public class JavaType implements Marker {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably move this marker to rewrite-core and name it something like TypeReference and then possibly add a language property to it. This way FindType, ChangeType and other recipes can support it and can at the same time be independent of the language that the markers occur in.

Laurens-W and others added 3 commits October 22, 2024 10:31
…java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants