Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARR test: remove loop to retry get notes and wait for process to finish instead #2470

Merged
merged 4 commits into from
Jan 15, 2025
Merged

ARR test: remove loop to retry get notes and wait for process to finish instead #2470

merged 4 commits into from
Jan 15, 2025

Conversation

melisabok
Copy link
Member

@melisabok melisabok commented Jan 15, 2025 •
edited
Loading

  • Remove infinite loop.
  • Assert that members were correctly added to the group members.
  • Check correct exception is thrown.
  • Add test to get notes by domain

@melisabok melisabok changed the title remove loop ARR test: remove loop to retry get notes and wait for process to finish instead Jan 15, 2025
@melisabok melisabok marked this pull request as ready for review January 15, 2025 17:58
@carlosmondra
Copy link
Member

I had to rerun the tests :/

@carlosmondra carlosmondra merged commit 2e8d4ce into master Jan 15, 2025
6 checks passed
@carlosmondra carlosmondra deleted the fix/arr-loop-tests branch January 15, 2025 23:43
@melisabok
Copy link
Member Author

yes, it is failing to me in localhost too so I didn't fix the problem entirely. I will check this again.

@haroldrubio
Copy link
Member

Hmm I've been trying for a few hours in my machine and haven't been able to get the ARR tests to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haroldrubio haroldrubio haroldrubio approved these changes

@celestemartinez celestemartinez celestemartinez approved these changes

@carlosmondra carlosmondra carlosmondra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@melisabok @carlosmondra @haroldrubio @celestemartinez