Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/journal issues #2466

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Fix/journal issues #2466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b635816
remove readers as nonreaders of AE paper group
celestemartinez Jan 8, 2025
211c059
allow AEs to report archived reviewers
celestemartinez Jan 9, 2025
8f23ab2
Merge branch 'master' into fix/journal-issues
celestemartinez Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion openreview/journal/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,6 @@ def setup_submission_groups(self, note):
if not action_editors_group:
action_editors_group=self.post_group(Group(id=action_editors_group_id,
readers=['everyone'],
nonreaders=[authors_group_id],
writers=[venue_id],
signatures=[venue_id],
signatories=[venue_id],
Expand Down
4 changes: 2 additions & 2 deletions openreview/journal/process/reviewer_report_pre_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ def process(client, edit, invitation):

reviewer_id=edit.note.content['reviewer_id']['value']

if not client.get_groups(id=journal.get_reviewers_id(), member=reviewer_id):
raise openreview.OpenReviewException(f'Invalid reviewer id {reviewer_id}, make sure the reviewer is part of the reviewers group')
if not client.get_groups(id=journal.get_reviewers_id(), member=reviewer_id) and not client.get_groups(id=journal.get_reviewers_archived_id(), member=reviewer_id):
raise openreview.OpenReviewException(f'Invalid reviewer id {reviewer_id}, make sure the reviewer is part of the reviewers or archived reviewers group')
12 changes: 12 additions & 0 deletions tests/test_journal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4900,6 +4900,18 @@ def test_archived_action_editor(self, journal, openreview_client, test_client, h
assert openreview_client.get_edges_count(invitation='TMLR/Reviewers/-/Pending_Reviews', tail='~David_Belanger1') == 0
assert openreview_client.get_edges_count(invitation='TMLR/Reviewers/-/Custom_Max_Papers', tail='~David_Belanger1') == 0

# post a reviewer report about an archived reviewer TMLR/Reviewers/-/Reviewer_Report
reviewer_report = raia_client.post_note_edit(invitation=f'{venue_id}/Reviewers/-/Reviewer_Report',
signatures=['~Raia_Hadsell1'],
note=Note(
content={
'reviewer_id': { 'value': '~David_Belanger1' },
'report_reason': { 'value': ['Reviewer never submitted their review'] },
'comment': { 'value': 'This is a comment.' }
}
)
)
helpers.await_queue_edit(openreview_client, edit_id=reviewer_report['id'])

## Carlos Mondragon
paper_assignment_edge = joelle_client.post_edge(openreview.api.Edge(invitation='TMLR/Reviewers/-/Assignment',
Expand Down