Feature: add option to delay new assignments after review has been submitted #2464
+68
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
Jan 8, 2025
openreview/journal/invitation.py
Outdated
| if self.journal.get_assignment_delay_after_submitted_review() > 0: | ||
| weeks = datetime.timedelta(weeks=self.journal.get_assignment_delay_after_submitted_review()) | ||
| milliseconds = int(weeks.total_seconds() * 1000) | ||
| invitation['postprocesses'] = [ |
There was a problem hiding this comment.
The postprocess will run after a reply is posted to the invitation, so kind of like the process function. However, we can add a delay, so the postprocess will run after the specified delay (in ms). More info here: https://github.com/openreview/openreview-api/pull/630
There was a problem hiding this comment.
can we always add this post process and if the delay is 0 then we update the pending review edge right away?
then we need to remove the code that updates the edge in the review process
melisabok
reviewed
Jan 9, 2025
| @@ -8,7 +8,7 @@ parameters: | |||
| default: "master" | |||
| openreview-api-v2-branch: | |||
| type: string | |||
| default: "main" | |||
| default: "feature/postprocesses" | |||
There was a problem hiding this comment.
we need to wait until this is merged before merging this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TMLR wants there to be a 2 week delay between when a reviewer submits their review and when they are once again available to be assigned to a new paper.
In this case, I implemented a post process that will run 2 weeks after the review was submitted to decrease the pending reviews counter. If the journal does not want a delay, the counter is decreased as soon as the review is posted.