Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update iThenticate EULA version using dateprocess functions #2431

Merged
merged 13 commits into from
Jan 17, 2025

Conversation

akshatchhabra
Copy link
Contributor

  1. Introduced a function to create submission invitations for iThenticate venues.
  2. The submission invitation includes a date-process function that does the following:
    • Check the EULA version in the submission form.
    • Compare it against the current EULA version obtained from iThenticate.
  3. If there is a version mismatch:
    • The date-process function posts an invitation edit.
    • This edit is made using the meta invitation.

Comment on lines 499 to 502
if self.iThenticate_plagiarism_check:
self.invitation_builder.set_iThenticate_submission_invitation()
else:
self.invitation_builder.set_submission_invitation()
Copy link
Member

@carlosmondra carlosmondra Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have something like this:

Suggested change
if self.iThenticate_plagiarism_check:
self.invitation_builder.set_iThenticate_submission_invitation()
else:
self.invitation_builder.set_submission_invitation()
self.invitation_builder.set_submission_invitation()
if self.iThenticate_plagiarism_check:
self.invitation_builder.set_iThenticate_fields()

That way if the logic in the method invitation_builder.set_submission_invitation() changes, we don't have to change it in two different places. It will also make the logic in self.invitation_builder.set_iThenticate_fields() simpler as we will only need to add the iThenticate fields.

@akshatchhabra akshatchhabra marked this pull request as ready for review December 5, 2024 17:03
@melisabok melisabok merged commit 72caa6c into master Jan 17, 2025
6 checks passed
@melisabok melisabok deleted the feat/ithenticate-eula-dateprocess branch January 17, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants