-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update iThenticate EULA version using dateprocess functions #2431
Conversation
akshatchhabra
commented
Nov 20, 2024
- Introduced a function to create submission invitations for iThenticate venues.
- The submission invitation includes a date-process function that does the following:
- Check the EULA version in the submission form.
- Compare it against the current EULA version obtained from iThenticate.
- If there is a version mismatch:
- The date-process function posts an invitation edit.
- This edit is made using the meta invitation.
openreview/venue/venue.py
Outdated
if self.iThenticate_plagiarism_check: | ||
self.invitation_builder.set_iThenticate_submission_invitation() | ||
else: | ||
self.invitation_builder.set_submission_invitation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have something like this:
if self.iThenticate_plagiarism_check: | |
self.invitation_builder.set_iThenticate_submission_invitation() | |
else: | |
self.invitation_builder.set_submission_invitation() | |
self.invitation_builder.set_submission_invitation() | |
if self.iThenticate_plagiarism_check: | |
self.invitation_builder.set_iThenticate_fields() |
That way if the logic in the method invitation_builder.set_submission_invitation()
changes, we don't have to change it in two different places. It will also make the logic in self.invitation_builder.set_iThenticate_fields()
simpler as we will only need to add the iThenticate fields.
* Since iThenticate calls in process function cannot be mocked