Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARR: Check for duplicate signatures before copying #2414

Merged
merged 15 commits into from
Jan 27, 2025

Conversation

haroldrubio
Copy link
Member

@haroldrubio haroldrubio commented Nov 5, 2024

Resolves #2368 and resolves #2376

Before the changes to the script, the additional registration form in the June cycle would break the tests since the registration tests have a maxReplies of 1

@haroldrubio haroldrubio added the arr Issues related to the ARR workflow label Nov 5, 2024
@haroldrubio haroldrubio self-assigned this Nov 5, 2024
@haroldrubio haroldrubio marked this pull request as ready for review December 9, 2024 18:50
@melisabok
Copy link
Member

melisabok commented Jan 27, 2025

This is a reminder how to fix a bug:

  1. Write a test to reproduce it, expect an assertion to fail (in this case: the multi reply error)
  2. Modify the code that fixes the bug
  3. Re-run the test and expect the test to pass

The last commits don't even pass because the test itself has bugs. You need to run the test in your machine and do the 3 steps that I mentioned before.

No matter how long it takes.

@haroldrubio
Copy link
Member Author

I've been using the CircleCI tests to run my tests because there's some strange bug in my local that's preventing even master from passing

@melisabok
Copy link
Member

Fix master in your machine first before doing anything.

@celestemartinez celestemartinez merged commit 0668ee5 into master Jan 27, 2025
6 checks passed
@celestemartinez celestemartinez deleted the fix/arr-copy-check-sigs branch January 27, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arr Issues related to the ARR workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARR: Withdrawn submissions failing previous URL validation ARR: Avoid posting notes twice when copying data
3 participants