Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARR: Enable SACs/ACs to add/remove others from commenting #2381

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

haroldrubio
Copy link
Member

Resolves #2263

Depends on openreview-web#2133

This PR adds a new type to the ARRStage Commentary_Control and builds the invitations similar to how the registration forms are generated:

  • Create a super invitation ARRCycle/-/Commentary_Control to store the process script
  • For each submission, post an invitation for Commentary_Control_Form and post a note to that invitation
  • Use this new note as the forum and reply to for the child invitations SubmissionX/-/Commentary_Control

Replies to the child invitation will modify fields in the SubmissionX/-/Official_Comment invitation

The super invitation does not have the invitation_edit_process date process function since the child invitations require an extra field in their edit content:

'responseForumId': {
    'value': {
        'param': {
            'type': 'string'
        }
    }
}

TODO:

  • Prevent request form overwriting in specific cases
  • Adjust wording/invitation names to make sense
  • Simplify process function logic (was originally designed to add/remove reviewers as well)

Links in the consoles:
Screenshot 2024-10-16 at 7 45 07 AM

Forum page example:
Screenshot 2024-10-16 at 7 45 37 AM

@haroldrubio haroldrubio added the arr Issues related to the ARR workflow label Oct 16, 2024
@haroldrubio haroldrubio self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arr Issues related to the ARR workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARR: Let assigned SACs/ACs add or remove the authors from the comment invitation
1 participant