Fix/journal issues (#2466)

* remove readers as nonreaders of AE paper group

* allow AEs to report archived reviewers

openreview/journal/group.py

@@ -454,7 +454,6 @@ def setup_submission_groups(self, note):
         if not action_editors_group:
             action_editors_group=self.post_group(Group(id=action_editors_group_id,
                 readers=['everyone'],
-                nonreaders=[authors_group_id],
                 writers=[venue_id],
                 signatures=[venue_id],
                 signatories=[venue_id],

openreview/journal/process/reviewer_report_pre_process.py

@@ -4,5 +4,5 @@ def process(client, edit, invitation):
 
     reviewer_id=edit.note.content['reviewer_id']['value']
 
-    if not client.get_groups(id=journal.get_reviewers_id(), member=reviewer_id):
-        raise openreview.OpenReviewException(f'Invalid reviewer id {reviewer_id}, make sure the reviewer is part of the reviewers group')
+    if not client.get_groups(id=journal.get_reviewers_id(), member=reviewer_id) and not client.get_groups(id=journal.get_reviewers_archived_id(), member=reviewer_id):
+        raise openreview.OpenReviewException(f'Invalid reviewer id {reviewer_id}, make sure the reviewer is part of the reviewers or archived reviewers group')

tests/test_journal.py

@@ -4900,6 +4900,18 @@ def test_archived_action_editor(self, journal, openreview_client, test_client, h
         assert openreview_client.get_edges_count(invitation='TMLR/Reviewers/-/Pending_Reviews', tail='~David_Belanger1') == 0
         assert openreview_client.get_edges_count(invitation='TMLR/Reviewers/-/Custom_Max_Papers', tail='~David_Belanger1') == 0
 
+        # post a reviewer report about an archived reviewer TMLR/Reviewers/-/Reviewer_Report
+        reviewer_report = raia_client.post_note_edit(invitation=f'{venue_id}/Reviewers/-/Reviewer_Report',
+            signatures=['~Raia_Hadsell1'],
+            note=Note(
+                content={
+                    'reviewer_id': { 'value': '~David_Belanger1' },
+                    'report_reason': { 'value': ['Reviewer never submitted their review'] },
+                    'comment': { 'value': 'This is a comment.' }
+                }
+            )
+        )
+        helpers.await_queue_edit(openreview_client, edit_id=reviewer_report['id'])
 
         ## Carlos Mondragon
         paper_assignment_edge = joelle_client.post_edge(openreview.api.Edge(invitation='TMLR/Reviewers/-/Assignment',