-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: prevent integer overflow when calculating azimuth in FURUNO scn files #138
Conversation
We can't really test this without having a file which contains that issue. Or we would need to think to refactor the code into functions we can test. Until now we just might have to live with the current state of affairs. |
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 20 20
Lines 3436 3436
=======================================
Hits 3035 3035
Misses 401 401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@mgrover1 I'll go ahead and merge tomorrow. Will also do a new release then. |
I can give you more files with this problem if you need |
No worries @giacant, I was thinking about that refactor for some while now. No need to have a file for this right now. BTW, would you mind testing that branch? Just in case. 😀 |
Yes, if you explain me how😀 |
https://docs.openradarscience.org/projects/xradar/en/stable/installation.html Section: From sources. Just clone from my fork and check out this very branch. |
I'm using anaconda 3, no matters? |
Yep, just create a new environment for that test. You can throw it away after that. |
Ok, I think i do that, now the versione of xradar is xradar 0.4.1.dev3+g2bbb5cd But i still have the error when plot snc file |
@giacant That version is the latest version on main. Try that, it should directly install this branch.
|
OK, now it works! |
history.md