Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new architecture diagram #47

Merged
merged 11 commits into from
Aug 21, 2023
Merged

Add new architecture diagram #47

merged 11 commits into from
Aug 21, 2023

Conversation

DriesSchaumont
Copy link
Member

Changelog

Add new architecture diagram

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-21 12:33 UTC

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

fundamentals/concepts.qmd Outdated Show resolved Hide resolved
contributing/project_structure.qmd Outdated Show resolved Hide resolved
fundamentals/concepts.qmd Outdated Show resolved Hide resolved
fundamentals/concepts.qmd Outdated Show resolved Hide resolved
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you accept these minor suggestions

fundamentals/architecture.qmd Outdated Show resolved Hide resolved
fundamentals/architecture.qmd Outdated Show resolved Hide resolved
fundamentals/architecture.qmd Outdated Show resolved Hide resolved
fundamentals/architecture.qmd Outdated Show resolved Hide resolved
Co-authored-by: Robrecht Cannoodt <[email protected]>
@DriesSchaumont DriesSchaumont merged commit 1256e54 into main Aug 21, 2023
1 check passed
@rcannood rcannood deleted the new_architecture_diagram branch August 21, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants