-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atac_marker_peaks component #879
base: main
Are you sure you want to change the base?
Conversation
mdata = mudata.read(par["input"].strip()) | ||
mod = mdata.mod[par["modality"]] | ||
|
||
if "peak_annotation" not in mod.uns["atac"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create an argument for the location of the peaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default value from muon
: https://muon.readthedocs.io/en/latest/api/generated/muon.atac.tl.add_peak_annotation.html
Other muon
functions check exactly this location, so if we store it somewhere else, the errors will appear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what we could do is add an argument here (with a default value peak_annotation
) and also add this argument to other components where needed?
Changelog
Add a component to calculate differentially accessible peaks for ATAC data.
Issue ticket number and link
Contributes to #398
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!