Add TF-IDF normalization #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSchaumont
requested changes
Aug 30, 2024
Co-authored-by: Dries Schaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
DriesSchaumont
requested changes
Sep 25, 2024
| - name: "--scale_factor" | ||
| type: integer | ||
| description: Scale factor to multiply the TF-IDF matrix by. | ||
| default: 10000 |
There was a problem hiding this comment.
Well, numbers less than 0 make little sense. Anything above can theoretically be used
There was a problem hiding this comment.
I set it to 1. Likely, less then this will not be used
Co-authored-by: Dries Schaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
Co-authored-by: Dries Schaumont <[email protected]>
DriesSchaumont
approved these changes
Sep 26, 2024
dorien-er
pushed a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: DriesSchaumont <[email protected]>
dorien-er
pushed a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: DriesSchaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add TF-IDF normalization for ATAC data.
Issue ticket number and link
Contributes to #398
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!