Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging output to metadata/add_id component. #663

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

DriesSchaumont
Copy link
Member

Changelog

Add more logging output to metadata/add_id component.

Issue ticket number and link

Partial fulfillment for #649

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont marked this pull request as ready for review January 18, 2024 12:10
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DriesSchaumont DriesSchaumont merged commit 477c161 into main Jan 19, 2024
6 checks passed
@DriesSchaumont DriesSchaumont deleted the add_id_logging branch January 23, 2024 14:17
VladimirShitov pushed a commit that referenced this pull request Mar 12, 2024
* Add more logging output to add_id component.

* Update CHANGELOG

* Added some quotes

* Add PR number to CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants