-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kathryn ods patch 1 #723
base: main
Are you sure you want to change the base?
Kathryn ods patch 1 #723
Conversation
componentRecords in this example were statementIds but should be recordIds
componentStatements was statementIds but should be recordIds
componentRecords was statementIds but should be recordIds
fixing a typo
changing statementIds to recordIds in componentRecords
@kathryn-ods - you can remove your changes to examples/bods-package-fi-soe.json from this PR, since I fixed the component recordId in PR #727 |
Have done this now and re-requested a review |
having an issue with the link check tests - https://www.iso20022.org/market-identifier-codes showing as broken |
ok I removed and readded the link and that seems to have worked |
@kathryn-ods - I'll take a look at this Wed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of the example files could do with checking again.
It's a headache getting these componentRecords lists right.
Overview
What does this pull request do?
updates example data - componentRecords fields were listing statementIds, now they list recordIds
How can a reviewer test or examine your changes?
Who is best placed to review it?
Closes #
Translations
translating. See the Handbook
Documentation & Release