Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Analytics & update privacy policy #280

Merged
merged 7 commits into from
Nov 12, 2020

Conversation

Lathrisk
Copy link

@Lathrisk Lathrisk commented Feb 17, 2020

@stevenday
Copy link

FYI @Lathrisk and @timgdavies - I've now removed Piwik/Matamo in this PR as well, and I've taken a first stab at updating the privacy notice regarding GA. I'll add a formal review with the next steps so it's clear why we're not merging this yet.

Copy link

@stevenday stevenday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To merge this we still need to:

  • Remove the translations for the privacy page, so that they are always in English
  • Get the google analytics text checked by OO's lawyer and confirm whether we need to take any additional measures now that we're using cookies.

@stevenday
Copy link

We're going to leave this open until OO have finished some ongoing work around GDPR compliance across all their sites and systems, so that we can be sure we're doing things properly.

@stevenday
Copy link

stevenday commented Aug 18, 2020

I've been doing that GDPR work I mentioned (in March 😱) and I've updated this so that:

  1. It's using Google Analytics setting to anonymise people's IP addresses
  2. It's not allowing Google analytics to set cookies at all
  3. The privacy policy page just points people to OpenOwnership's master privacy policy (which is not live yet)

In addition, I've removed hypothesis, since it's adding cookies and probably collecting data that our privacy policy doesn't over. I'll await some confirmation that this is ok before making this permanent.

On translations, this now has new privacy notice content, so will need translation into Russian and Spanish. However, since it's just a pointer to another page I think we can keep translating it, which simplifies things quite a bit. In the interim we can probably live with this page being in English as a single sentence with a link at the end is probably understandable enough for anyone (especially when they're going to have to read the legalese in English anyway).

I checked, and the privacy page is only on v0.2, I think we can live with just porting these changes to that version for now.

I think the outstanding things now are:

  • Getting the new OO privacy policy checked and live
  • Confirming if we can remove Hypothesis or if we need a cookie banner + privacy policy text to cover it

@Bjwebb
Copy link
Collaborator

Bjwebb commented Aug 18, 2020

Do the Data Review Tool terms also need updating? openownership/cove-bods#36

@kd-ods
Copy link
Collaborator

kd-ods commented Aug 18, 2020

@stevenday Hypothesis is a plugin that allows annotations to be added to text on ReadTheDocs. I think it's used as part of the review workflow for translations so maybe hold off on removing it until you've checked in with @siwhitehouse. (He's away atm.)

As we improve the docs, I do like the idea of having an annotation mechanism for people to pose questions or request clarifications. Would any of the info here help us retain Hypoths.is?

@stevenday
Copy link

@Bjwebb

Do the Data Review Tool terms also need updating? openownership/cove-bods#36

I looked at those briefly and thought that it seems standalone enough and detailed enough to leave it alone for now. The ticket doesn't make clear what exactly needs updating - it looks to be ok from my quick scan?

If you would like to transfer more legal responsibility for the service to OO, we could look at bringing it under the same policy, but I'd like to get it launched before we do that.

@kd-ods

Thanks for the explanation and the link. At a first reading I disagree with their statements there - in my (admittedly brief) the plugin sets a cookie as soon as you load a page, whether you're logged in or not. This is not necessarily a GDPR issue, but it is a cookie law issue so they're not right to say they don't need a cookie notice. I'll investigate more if @siwhitehouse is keen to keep it, it's not the end of the world if we have to have one, just a bit of hassle to implement.

@stevenday stevenday changed the title Add Google Analytics Add Google Analytics & update privacy policy Aug 18, 2020
@stevenday stevenday dismissed their stale review August 18, 2020 16:06

This is out of date

@Bjwebb
Copy link
Collaborator

Bjwebb commented Aug 21, 2020

@stevenday

Yes, I think its mostly fine. I think there's a few bits where e.g. the name of the standard is missing, but that should be fairly easy to fix, compared to overhauling the whole thing.

@siwhitehouse
Copy link
Contributor

siwhitehouse commented Aug 25, 2020

@stevenday We discussed this today and agreed that we can remove Hypothes.is.

For translation work we use the commenting function in Transifex for comments and queries. I think we have previously discussed the possibility that regular users could comment on the quality of a translation through Hypothes.is.

In practice we do not have people making comments about either the content or its translation through Hypothes.is and I suspect this would continue to be the case unless we were to actively encourage people to use it. We don't have it installed on other data standard documentation sites that we maintain.

Jared Parnell and others added 7 commits November 11, 2020 16:28
With Google Analytics in place, we don't need both
This doesn't appear anywhere I can see, so for clarity I'm removing it.
We don't use it, it sets cookies we'd otherwise have to disable and
probably collects information we'd have to explain in our privacy
policy. It's altogether easier to just get rid of it.
@stevenday
Copy link

@kd-ods or @siwhitehouse - would you mind giving this a quick once over and approving? Nothing is new, but we've finally, (finally!) got the main new privacy policy up and running at: https://www.openownership.org/privacy/ so we can merge this PR too.

@stevenday stevenday removed the WIP label Nov 12, 2020
@stevenday stevenday requested review from kd-ods and siwhitehouse and removed request for timgdavies November 12, 2020 08:56
Copy link
Collaborator

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Steve.

@stevenday stevenday merged commit 7693b43 into master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put user analytics system in place
5 participants