Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the wrong eslint version being used in examples/create-next-app #55

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix the wrong eslint version being used in examples/create-next-app #55

merged 2 commits into from
Oct 3, 2024

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Oct 3, 2024 •
edited
Loading

it's quite minor, but we do get this eslint error when running the create-next-app example:
Screenshot 2024-10-03 at 12 22 12

example in a gh run

I think this is caused by us using the wrong eslint version in the app, so that's what I am addressing in this PR

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review October 3, 2024 11:37
@dario-piotrowicz dario-piotrowicz requested a review from vicb October 3, 2024 11:37
vicb
vicb approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vicb vicb merged commit 5105d31 into main Oct 3, 2024
2 checks passed
@vicb vicb deleted the dario/create-next-app-eslint-extensions-fix branch October 3, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dario-piotrowicz @vicb