Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all references to wrangler.toml #48

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Jan 13, 2025

Since we're moving to promoting the json format (cloudflare/workers-sdk#7676) instead of toml for the wrangler config I went back to the Cloudflare docs here to remove all references to wrangler.toml

Note

I didn't remove those from the 0.2 section as I think it should be kept there.

Although I would actually prefer to get rid of the 0.2 section altogether, especially since we had this section+migration for a while (devs that were on 0.2 would most likely have already migrated) and the package itself is still in beta/experimental anyways.
@vicb any plan/idea if/when we can remove the 0.2 docs?

Note

As you can see in this PR my preference when referring to the config file is to generically call it something like wrangler configuration file instead of directly wrangler.json I think that that's just more accurate and future proof (if for example we later decide to default to wrangler.jsonc for example, or even to a wrangler.config.ts, all the generic references to the file would still be correct and wouldn't need to be updated)

@dario-piotrowicz dario-piotrowicz requested a review from vicb January 13, 2025 10:41
@vicb vicb merged commit b1ab51d into opennextjs:main Jan 14, 2025
1 check passed
@dario-piotrowicz dario-piotrowicz deleted the dario/no-toml branch January 14, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants