Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync aws doc with code #34

Merged
merged 24 commits into from
Nov 26, 2024
Merged

sync aws doc with code #34

merged 24 commits into from
Nov 26, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 25, 2024

No description provided.

@vicb vicb requested a review from conico974 November 26, 2024 07:39
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little comment, other than that LGTM

pages/aws/config/custom_overrides.mdx Outdated Show resolved Hide resolved
pages/aws/config/custom_overrides.mdx Outdated Show resolved Hide resolved
pages/aws/config/custom_overrides.mdx Outdated Show resolved Hide resolved
pages/aws/config/custom_overrides.mdx Outdated Show resolved Hide resolved
pages/aws/config/custom_overrides.mdx Outdated Show resolved Hide resolved
pages/aws/config/custom_overrides.mdx Outdated Show resolved Hide resolved
pages/aws/contribute/local_run.mdx Outdated Show resolved Hide resolved
pages/aws/contribute/local_run.mdx Outdated Show resolved Hide resolved
pages/aws/contribute/local_run.mdx Outdated Show resolved Hide resolved
pages/aws/contribute/local_run.mdx Outdated Show resolved Hide resolved
pages/aws/inner_workings/cache_interception.mdx Outdated Show resolved Hide resolved
@vicb vicb requested a review from conico974 November 26, 2024 09:36
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit c0d3199 into main Nov 26, 2024
1 check passed
@vicb vicb deleted the sync branch November 26, 2024 10:14
@vicb
Copy link
Contributor Author

vicb commented Nov 26, 2024

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants