-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate main pages #984
base: master
Are you sure you want to change the base?
Translate main pages #984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found several issues.
"server-sumbitted": "serverCodeHn} is added to our pending list. If it's not available after maximum 48 hours, you can contact us on Discord!",
Missing { "serverCodeHn}
"Partners (BETA TESTERS)" : "Partnerler (BETA TESTERLER)",
"Partnerler (BETA TESTERLER)"
is Turkish and it repeated in all translation files.
"Documentation": "Documentatio",
Documentatio
spelling mistake.
"IP/Domain": "AIP/Domain",
AIP
to IP
"Change language from English": "Change language from English",
It doesn't need the name of the language.
<ModalHeader>{translateText(locale, "General", `Change language from ${getLanguageName(locale)}`)}</ModalHeader>
So just:
"Change language from ": "Change language from ",
I come to the conclusion that this is not good.
"Index": {
"Getting Started": "Getting started",
"Fully backwards compatible with existing scripts and clients": "Fully backwards compatible with existing scripts and clients",
"index-text-1": "Getting started",
"index-text-2": "Fully backwards compatible with existing scripts and clients", Or like this: https://github.com/openmultiplayer/launcher/blob/master/src/locales/translations/en.ts
But please don't make any changes for now, let other team members decide. |
I'm not entirely sure how I feel about introducing a new way for translations while docs use directory based files @Southclaws what are your thoughts on this? |
Barnaby had already said that it should be like this @AmyrAhmady (key-value) |
No description provided.