(chore) O3-4255: Bump @carbon/react to v1.17.0 #85
Conversation
|
@NethmiRodrigo can you review this please? |
|
@dilankavishka the build is failing, and this specific build error usually happens when a |
NethmiRodrigo
changed the title
NethmiRodrigo
changed the title
|
@NethmiRodrigo I made the changes. Can you review this please? |
package.json
Outdated
| "@carbon/react": "^1.37.0", | ||
| "@openmrs/esm-framework": "next", | ||
| "@carbon/react": "1.71.0", | ||
| "@openmrs/esm-framework": "^6.0.1-pre.2544", |
There was a problem hiding this comment.
@dilankavishka this version and the version of openmrs should be reverted back to next. There's a step in the docs that you probably missed, where after upgrading the core and framework, you should checkout package.json and then run yarn again
There was a problem hiding this comment.
Done! I've reverted the version to next.
tsconfig.json
Outdated
| ], | ||
| "resolveJsonModule": true, | ||
| "noEmit": true, | ||
| "target": "esnext", | ||
| "target": "es2022", |
There was a problem hiding this comment.
Why were this and lib versions changed?
There was a problem hiding this comment.
It gives an error while run yarn test and asked for change the tsconfig.json to the latest versions. that's why I changed that.
There was a problem hiding this comment.
should I keep the same or need to revert back this also?
There was a problem hiding this comment.
We should revert back these changes. If lint or tests are failing, it could be because of the carbon upgrade and we should fix that
There was a problem hiding this comment.
Done! and now it's working perfectly.
|
@NethmiRodrigo I made the changes you mentioned. can you review this please? |
|
Thanks @dilankavishka! You were right about the tsconfig, but we only had to add it to the |
Cuts a minor release of Fast Data Entry, `v1.1.0` with some new features and housekeeping. Here's the draft changelog: * (feat) Add ability to disable and set default values for answers in specificQuestions by @icrc-jofrancisco in #84 * (feat) Support for static specific answers by @icrc-jofrancisco in #87 * (chore) O3-4255: Bump @carbon/react to v1.17.0 by @dilankavishka in #85
Requirements
Summary
Carbon version updated to v1.71.0
Screenshots
Screen.Recording.2024-12-11.at.00.08.11.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-4255
Other