-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-4366: Change languages in my account panel to sentence case #1277
(fix) O3-4366: Change languages in my account panel to sentence case #1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @harshthakkr!
...esm-primary-navigation-app/src/components/change-language/change-language-link.extension.tsx
Outdated
Show resolved
Hide resolved
...esm-primary-navigation-app/src/components/change-language/change-language-link.extension.tsx
Outdated
Show resolved
Hide resolved
They seem OK here... |
Just wanted to confirm, did you use this syntax: |
I've not run the tests locally. What error are you seeing? It's not clear from the screenshot where the error is. |
I see. Add the following line: 'lodash-es/(.*)': 'lodash/$1' , to the primary-navigation app's jest config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @harshthakkr!
Thank you, @denniskigen! |
@@ -5,6 +5,7 @@ module.exports = { | |||
}, | |||
transformIgnorePatterns: [], | |||
moduleNameMapper: { | |||
'lodash-es/(.*)': 'lodash/$1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is post-commit, but the reason that this rule didn't exist is because we want you to use import { captialize } from 'lodash-es'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must've got this lopsided, sorry, @harshthakkr.
I thought we preferred import capitalize from 'lodash-es/capitalize'
@ibacher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With lodash
, but not lodash-es
that was the case. lodash-es
is packaged as a ES Module whereas lodash
is, I think, common-js, so importing import {capitalize} from 'lodash'
ends up including all of lodash
, but import {capitalize} from 'lodash-es'
only imports the relevant parts of lodash-es
—which is exactly what import capitalzie from 'lodash/capitalize'
also accomplishes.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
All language names in the “My Account” panel now follow the same sentence case format as seen in the “Change Language” modal, providing a consistent experience across the application:
Screenshots
Before
After
Related Issue
O3-4366