Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning to run_model_on_task to avoid duplicates if no authentication #1240

Closed
wants to merge 26 commits into from
Closed

Added warning to run_model_on_task to avoid duplicates if no authentication #1240

wants to merge 26 commits into from

Conversation

v-parmar
Copy link
Contributor

@v-parmar v-parmar commented Mar 29, 2023 •
edited
Loading

Reference Issue

#1210

v-parmar and others added 16 commits March 28, 2023 01:19
@v-parmar
Update extension.py
4949343 
added missing documentation
@v-parmar
Update task.py
d480a8c 
added missing documentation
@v-parmar
Update flow.py
07bf011 
added missing documentation
@v-parmar
Update functions.py
717eaef 
added missing documentation
@v-parmar
Update /runs/functions.py
00422d2 
added missing documentation
@v-parmar
Update trace.py
7c97f01 
added missing documentation
@v-parmar
Update /setups/functions.py
7fad057 
added missing documentation
@v-parmar
Update study/functions.py
5146226 
added missing documentation
@v-parmar
Update tasks/functions.py
10d7bd4 
added missing documentation
@v-parmar
Update split.py
6bc76a5 
added missing documentation
@v-parmar
Update /tasks/task.py
7fd1706 
added missing documentation
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c12b285 
for more information, see https://pre-commit.ci
@v-parmar
Update functions.py
9a06a5d 
Added warning to run_model_on_task to avoid duplicates if no authentication
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
439111a 
for more information, see https://pre-commit.ci
@v-parmar
Update functions.py
1b92d21 
Added warning to run_model_on_task to avoid duplicates if no authentication
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cf3a238 
for more information, see https://pre-commit.ci
@LennartPurucker
Copy link
Contributor

Hey @v-parmar, thank you for this PR.

Could you perhaps remove the other commits/changes that are not related to the issue and the purpose of this PR?
I think your other PR (#1239) covers these changes already.

@LennartPurucker
Copy link
Contributor

Hey, @v-parmar, I think you deleted a lot of files to roll back your changes. We can not merge it like this.
I think it might be best if you reset your branch to the current dev branch and then add your specific change by hand again.

This should allow us to have the PR only for the specific change it is supposed to fix.

@v-parmar v-parmar closed this Apr 18, 2023
@v-parmar v-parmar deleted the v-parmar-patch-1 branch April 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-parmar @LennartPurucker