Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoUpdateStrategy & new Type OnlyNew #119

Closed

Conversation

chrisliu1995
Copy link
Member

No description provided.

@kruise-bot kruise-bot requested review from FillZpp and zmberg December 18, 2023 08:59
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (250bd86) 32.63% compared to head (578d53d) 32.90%.
Report is 1 commits behind head on master.

Files Patch % Lines
...trollers/gameserverset/gameserverset_controller.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   32.63%   32.90%   +0.26%     
==========================================
  Files          23       23              
  Lines        3144     3167      +23     
==========================================
+ Hits         1026     1042      +16     
- Misses       2065     2072       +7     
  Partials       53       53              
Flag Coverage Δ
unittests 32.90% <69.56%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisliu1995 chrisliu1995 force-pushed the feat/auto_update branch 4 times, most recently from 6912c73 to 402bfbd Compare December 18, 2023 14:12
@ringtail
Copy link
Member

/close due to other update policy

@ringtail ringtail closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants