Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update physics and astronomy field keywords to reduce false positives #1292

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

dfm
Copy link
Contributor

@dfm dfm commented Nov 3, 2023

I've been finding that we've been getting a fair number of incorrect track assignments for general physics papers in the AASS track. This is because the labels "General Physics and Astronomy" and "Physics and Astronomy (misc)" were both being sent to AASS. This PR splits those field labels to assign "Physics" to the PE track and "Astronomy" to the AASS track.

cc @kyleniemeyer

@arfon
Copy link
Member

arfon commented Nov 7, 2023

Looks good @dfm! @xuanxu – what is the process for re-importing the subjects? Can we just re-run the rake task?

Copy link
Member

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I'll fix the build after merging it

@xuanxu
Copy link
Member

xuanxu commented Nov 7, 2023

@arfon to re-import just run the tracks:import:subjects task.
Before that you can run tracks:import:dry_run to make sure it'd work and get some info on what will be imported

@xuanxu xuanxu merged commit c08e21d into openjournals:main Nov 7, 2023
1 check failed
@arfon
Copy link
Member

arfon commented Nov 12, 2023

OK, those should be imported now @dfm

@dfm
Copy link
Contributor Author

dfm commented Nov 13, 2023

Thanks @arfon and @xuanxu!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants