Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346607: IGV: Support drag-and-drop for opening graph files #23040

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

theoweidmannoracle
Copy link
Contributor

@theoweidmannoracle theoweidmannoracle commented Jan 10, 2025

Adds the ability to drag-and-drop graph files into IGV.

A welcome screen invites users to drag and drop files:

Screen.Recording.2025-01-10.at.15.55.57.mov

The welcome screen disappears while any graphs have been imported (via opening a file or via socket) and reappears automatically if no graphs are imported in the workspace (that is, if the list on the left-hand side is completely empty).

Furthermore, graphs can be dropped at any time in the areas in the green boxes in the image below. The reason only these areas work is due to the unfortunate way in which Apache NetBeans handles drag and drop events, as many components just consume events they cannot process without offering any apparent way to customize the drop behavior.

Screenshot 2025-01-10 at 16 11 13

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346607: IGV: Support drag-and-drop for opening graph files (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23040/head:pull/23040
$ git checkout pull/23040

Update a local copy of the PR:
$ git checkout pull/23040
$ git pull https://git.openjdk.org/jdk.git pull/23040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23040

View PR using the GUI difftool:
$ git pr show -t 23040

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23040.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back tweidmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@theoweidmannoracle The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@theoweidmannoracle theoweidmannoracle marked this pull request as ready for review January 10, 2025 15:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant