8347129: cpuset cgroups controller is required for no good reason #23037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this small change to make the
cpuset
cgroups controller optional as far as the JDK is concerned. The rationale is that:--cpuset-cpus
is reflected with thesched_getaffinity
system call and, thus, the controller doesn't need to be mandatory. The current failure to detect the controller results in no container limits being detected with is bad.The fix is rather simple. Make
cpuset
controller look-up from/proc/cgroups
optional (like thepids
controller) and continue.OSContainer::active_processor_count()
still behaves as before (should there be acpuset
limit) as it's covered byos::Linux::active_processor_count()
which serves as the upper bound of other container cpu limits.While at it, I've also fixed the logging bug by re-arranging the
const char*
values.cpuset
is index0
,cpu
is index1
.Testing:
test/hotspot/jtreg/containers
on Linux cgroups v1 and cgroups v2 as well as on an affected system (F41 on cg v2). All pass.Thoughts?
Progress
Warning
8347129: cpuset cgroups controller is required for no good reason
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23037/head:pull/23037
$ git checkout pull/23037
Update a local copy of the PR:
$ git checkout pull/23037
$ git pull https://git.openjdk.org/jdk.git pull/23037/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23037
View PR using the GUI difftool:
$ git pr show -t 23037
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23037.diff
Using Webrev
Link to Webrev Comment