Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347129: cpuset cgroups controller is required for no good reason #23037

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jan 10, 2025

Please review this small change to make the cpuset cgroups controller optional as far as the JDK is concerned. The rationale is that:

  • Some distributions now don't have it enabled by default (e.g. Fedora 41), which breaks automatic container detection logic.
  • CPU limits enforced with --cpuset-cpus is reflected with the sched_getaffinity system call and, thus, the controller doesn't need to be mandatory. The current failure to detect the controller results in no container limits being detected with is bad.

The fix is rather simple. Make cpuset controller look-up from /proc/cgroups optional (like the pids controller) and continue. OSContainer::active_processor_count() still behaves as before (should there be a cpuset limit) as it's covered by os::Linux::active_processor_count() which serves as the upper bound of other container cpu limits.

While at it, I've also fixed the logging bug by re-arranging the const char* values. cpuset is index 0, cpu is index 1.

Testing:

  • GHA
  • Linux container tests in test/hotspot/jtreg/containers on Linux cgroups v1 and cgroups v2 as well as on an affected system (F41 on cg v2). All pass.

Thoughts?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8347129: cpuset cgroups controller is required for no good reason

Issue

  • JDK-8347129: cpuset cgroups controller is required for no good reason (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23037/head:pull/23037
$ git checkout pull/23037

Update a local copy of the PR:
$ git checkout pull/23037
$ git pull https://git.openjdk.org/jdk.git pull/23037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23037

View PR using the GUI difftool:
$ git pr show -t 23037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23037.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@jerboaa The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant