Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running #23036

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 10, 2025

The thread-per-task-executor returned by Executors.newVirtualThreadPerTaskExecutor will terminate without waiting for threads that are still executing cancelled tasks. This is different to ThreadPoolExecutor and ForkJoinPool that wait for the threads to finish executing the cancelled tasks. Note that issue with TPTE is specific to Callable tasks, Runnable tasks are not impacted. The change is to override FutureTask.run instead of FutureTask.done. Test coverage is expanded to cover this case.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23036/head:pull/23036
$ git checkout pull/23036

Update a local copy of the PR:
$ git checkout pull/23036
$ git pull https://git.openjdk.org/jdk.git pull/23036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23036

View PR using the GUI difftool:
$ git pr show -t 23036

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23036.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants