Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of events_delivered #109

Closed
wants to merge 5 commits into from

Conversation

appsdesh
Copy link
Contributor

Clarification of events_delivered from the past calls

The transmitter may reserve rights to deliver events on certain occasions such as (but not limited to) -

  1. Receiver has not paid for SKU that the event is part of,
  2. Receiver is not in the desired jurisdiction/compliance environment to receive the event

Discussion contexts -

  1. 4/4 https://hackmd.io/@oidf-wg-sse/wg-meeting-20230404
  2. 8/29 https://hackmd.io/nW6HWJ4WQfaX2ZAnm758Uw

transmitter MAY decide to deliver only a subset of events represented by
this intersection. These events MAY be delivered over the Event Stream. A
Receiver MUST rely on the values received in this field to understand which
event types it can expect from the Transmitter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested wording:
events_delivered

Transmitter-Supplied: An array of URIs identifying the set of events that the Transmitter SHALL include in the stream. This is a subset of the intersection of "events_supported" and "events_requested". A Receiver MUST rely on the values received in this field to understand which event types it can expect from the Transmitter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a subset of the intersection of "events_supported" and "events_requested"

I feel the above statement suggests that it will always be a subset, which may not be true.

If you are referring to "A set is a subset of itself" principle to describe this, I feel it may not be clear to an ordinary reader.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a mathematical term to specify the subset that isn't the "proper subset", then we can include that. In normative text, I prefer precision, but happy to consider opinions of other members. Perhaps we can say: "This is a subset (not necessarily a proper subset) of ..."

appsdesh added a commit that referenced this pull request Sep 14, 2023
Consolidating changes from PRs

1. #109
2. #108
3. #100
@appsdesh
Copy link
Contributor Author

Following up on #117

@appsdesh appsdesh closed this Sep 14, 2023
appsdesh added a commit that referenced this pull request Sep 22, 2023
Consolidating changes from PRs

1. #109
2. #108
3. #100
tulshi pushed a commit that referenced this pull request Sep 22, 2023
* Consolidating changes from PRs

Consolidating changes from PRs

1. #109
2. #108
3. #100

* Shayne's suggestion

Shayne's suggestion

* More places to fix MUST -> SHOULD

More places to fix MUST -> SHOULD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants