Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple SSF spec from OAuth2 scopes #101

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Decouple SSF spec from OAuth2 scopes #101

merged 1 commit into from
Oct 1, 2023

Conversation

appsdesh
Copy link
Contributor

As per the discussions from issue #95 and specifically this comment.

Proposing the changes to decouple SSF spec from OAuth 2 scopes/discovery

openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tulshi tulshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tim's comments.

Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Decouple SSF from OAuth protocol

- Revert #83
- Removed type from authorization scheme
- More OAuth agnostic changes
- Removed OPRM references
- spec_urn verbiage changes
- Removed OAuth2 references from the aud claim
@tulshi tulshi merged commit 82f0cae into main Oct 1, 2023
2 checks passed
@tulshi tulshi deleted the ssf-oauth-interfacing branch October 1, 2023 22:52
@tulshi tulshi linked an issue Dec 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Parameters for Receiver Streams
6 participants