-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple SSF spec from OAuth2 scopes #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcappalli
reviewed
Aug 22, 2023
tulshi
reviewed
Aug 24, 2023
tulshi
reviewed
Aug 24, 2023
tulshi
reviewed
Aug 28, 2023
timcappalli
reviewed
Aug 29, 2023
timcappalli
reviewed
Aug 29, 2023
adeinega
reviewed
Sep 6, 2023
adeinega
reviewed
Sep 6, 2023
tulshi
requested changes
Sep 22, 2023
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 22, 2023 17:52
963ec2b
to
c2baf3f
Compare
tulshi
reviewed
Sep 22, 2023
tulshi
reviewed
Sep 22, 2023
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 22, 2023 18:39
43f7598
to
28c9f64
Compare
tulshi
reviewed
Sep 22, 2023
tulshi
approved these changes
Sep 24, 2023
FragLegs
requested changes
Sep 26, 2023
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 26, 2023 16:24
74ff854
to
424fcb1
Compare
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 27, 2023 22:10
424fcb1
to
b5f838d
Compare
tulshi
approved these changes
Sep 27, 2023
timcappalli
requested changes
Sep 28, 2023
tulshi
reviewed
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Tim's comments.
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 29, 2023 16:40
fb3c058
to
e11ad19
Compare
tulshi
approved these changes
Sep 29, 2023
timcappalli
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 29, 2023 23:15
e11ad19
to
cff7480
Compare
Decouple SSF from OAuth protocol - Revert #83 - Removed type from authorization scheme - More OAuth agnostic changes - Removed OPRM references - spec_urn verbiage changes - Removed OAuth2 references from the aud claim
appsdesh
force-pushed
the
ssf-oauth-interfacing
branch
from
September 29, 2023 23:17
cff7480
to
f89404a
Compare
FragLegs
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussions from issue #95 and specifically this comment.
Proposing the changes to decouple SSF spec from OAuth 2 scopes/discovery