macOS: Improve HTML page when authorization completes in the browser #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roop
force-pushed
the
macos_better_looking_html_page
branch
from
9dd840e
to
69304aa
Compare
|
The "swift test" failure in travis-ci seems to be unrelated to this change -- it still fails without these changes. |
|
I like the idea of a nicer HTML page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AppAuth in macOS, AppAuth creates a local webserver in the app so that the authorization flow can use the default browser. Once the authorization flow completes, the page shown on the tab used for authorization is currently a very bare HTML page with no styling at all. This PR adds some basic styling that makes the page look better. The same HTML template is used in case authorization succeeded or failed.