New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce transaction scope #367

Open

fredkingham wants to merge 3 commits into v1.33 from reduce-transaction-scope

Contributor

fredkingham commented Jun 10, 2022 •

edited

Loading

This is probably more code than expected...

Things to note...

In d2da738 we removed the five year mean to diagnosis. A lot of this code dealt with that and was still hanging about (although not actually saving a fact). So this removes that code.
We were keeping one fact about and deleting the other. It doesn't actually matter as the calling code always got the latest fact but we may as well delete both to keep it consistent.

fredkingham added 3 commits

June 10, 2022 15:08


          Removes all the logic referenced by mean times to diagnosis as this f…

c71b199

…eature was removed at the users request in d2da738


          Changes cls into self as this is not a class method

20374d9


          Move the save logic into its own little transaction

99a561c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet