Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alexa metadata: Add UoM support to use new Item unit symbol property #2009

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Alexa metadata: Add UoM support to use new Item unit symbol property #2009

merged 1 commit into from
Aug 19, 2023

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Aug 7, 2023

@jsetton jsetton requested a review from a team as a code owner August 7, 2023 21:29
@relativeci
Copy link

relativeci bot commented Aug 7, 2023

Job #1102: Bundle Size — 15.75MiB (~-0.01%).

b701d9b(current) vs 8f1d239 main#1101(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (no changes)
                 Current
Job #1102		      Baseline
Job #1101
Initial JS 1.67MiB 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.95%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1102		      Baseline
Job #1101
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (~+0.01%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~-0.01%) 4.72MiB

View job #1102 report View main branch activity

@florian-h05 florian-h05 added the main ui Main UI label Aug 12, 2023
florian-h05
florian-h05 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 changed the title Update alexa uom support to use new item unit symbol property Alexa meradata: Add UoM support to use new Item unit symbol property Aug 19, 2023
@florian-h05 florian-h05 changed the title Alexa meradata: Add UoM support to use new Item unit symbol property Alexa metadata: Add UoM support to use new Item unit symbol property Aug 19, 2023
@florian-h05 florian-h05 added the enhancement New feature or request label Aug 19, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Aug 19, 2023
@florian-h05 florian-h05 merged commit ee7c5ad into openhab:main Aug 19, 2023
4 checks passed
@jsetton jsetton deleted the alexa-uom-unit-symbol branch August 19, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsetton @florian-h05