Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stray slash in notification icon URL generation. #793

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

maniac103
Copy link
Contributor

Causes 404 when fetching icon.

Causes 404 when fetching icon.

Signed-off-by: Danny Baumann <[email protected]>
@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #793 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   11.32%   11.32%           
=======================================
  Files          55       55           
  Lines        4556     4556           
  Branches      577      577           
=======================================
  Hits          516      516           
  Misses       3983     3983           
  Partials       57       57
Impacted Files Coverage Δ
...penhab/habdroid/ui/OpenHABNotificationAdapter.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8153da...b2445c2. Read the comment docs.

@mueller-ma mueller-ma added the bug Indicates an unexpected problem or unintended behavior label Mar 21, 2018
@mueller-ma
Copy link
Member

I haven't seen that // causes a 404. Can you provide an example link?

@maniac103
Copy link
Contributor Author

I have seen it during my tests with the URL https://myopenhab.org:443//images/smiley.png ... The proxying of the image from my own OH (1.8) instance failed in that case. Without the stray slash it worked fine.

@maniac103
Copy link
Contributor Author

Kai also stumbled over a similar issue: openhab/openhab-cloud#158 (comment) ... looks like openhab-cloud is a bit picky about the URLs thrown at it.

@mueller-ma mueller-ma merged commit a5fce3f into openhab:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants