Add v2 backward compatibility

[jsetton]

• restructured project to clearly separate v2/v3

[jsetton]

@digitaldan I decided to add v2 support back in the skill after reading this documentation which stipulates that the skill should handle both versions until the skill no longer receive any v2 requests.

Also looking at the live skill logs, there are a ton of payload version errors still and these are for actual user requests to control their smart home devices. So rather force these users to spend the time to figure out their issue, we might as well make the experience as smooth as possible 😄

Anyway, let me know what you think. I made a minor project restructuring and added a few minor changes including having rest requests accept gzip compression if available which I think should be enabled with the myopenhab cloud connector #253.

On a side note, the state field is still being pulled in this one. I am hoping that having the request data compressed would resolve that matter.

[jsetton]

Ended up finding a way to not use the state field during the discovery process. This means that we can now exclude it from that process 😄 Workaround details are in #257.

@digitaldan hopefully you have some time in the next few days to take a look at this one. I bunched all the changes in one PR. This should cover all the outstanding bug fixes on the skill side.

[jsetton]

So I decided to split the changes in this PR in order to push the discovery performance improvement to live skill while the v2 backward compatibility change can wait for your review. That way, we can see if the discovery change will result in less v2 requests.

[digitaldan]

Hey Jermey, i have been on vacation for the last week and am getting caught back up with OH stuff today, I will take a look at this and others, apologies for being MIA .

[digitaldan]

So given the size of the PR i will have to take your word on this one :-) I can't easily tell what code you had to change and what was pulled in from the v2 connecter. I hope it was not as much work as it looks.

[digitaldan]

Nm my previous comment, i was not looking at the PR correctly and seeing files renamed vs added. Changes looks good to me, super impressed at the v2 test classes you wrote, that does seem like a lot of work! Thanks!

[jsetton]

I hope it was not as much work as it looks.

Not too much 😄 I had to cleanup and update a bit of the v2 ohConnector to integrate into the current framework. Most of the change is from the folder restructure. I think it makes sense and was needed anyway.

super impressed at the v2 test classes you wrote, that does seem like a lot of work

That part was actually the easiest. We already had the test cases 😄

[jsetton]

So I just pushed #265 to the live skill and will wait a day before merging and pushing this one to prod. That way we can see if the discovery performance changes improve the number of users that weren't able to have their devices converted to v3 because of the timeout issue.

[digitaldan]

👍

[digitaldan]

How did #265 go? Do we need to push this one now?

[jsetton]

So I just opened #269 related to #265. I think we should resolve that one before merging this PR. Unless you think otherwise.