Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boschshc] Provide alarm channel for smoke detectors #18194

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[boschshc] Provide alarm channel for smoke detectors #18194

wants to merge 1 commit into from

Conversation

david-pace
Copy link
Member

@david-pace david-pace commented Jan 26, 2025 •
edited
Loading

  • add new channel definition for alarm channel in thing-types.xml
  • add alarm channel to Smoke Detector and Smoke Detector II
  • add update instruction sets in binding.xml
  • re-generate i18n properties file
  • add constant for new channel
  • implement alarm service
  • register service package in tests
  • extend abstract smoke detector handler
  • add unit tests
  • add documentation

closes #18161

@david-pace david-pace added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Jan 26, 2025
@david-pace
[boschshc] Provide alarm channel for smoke detectors
5f7531c 
* add new channel definition for alarm channel in thing-types.xml
* add alarm channel to Smoke Detector and Smoke Detector II
* add update instruction sets in binding.xml
* re-generate i18n properties file
* add constant for new channel
* implement alarm service
* register service package in tests
* extend abstract smoke detector handler
* add unit tests
* add documentation

Signed-off-by: David Pace <[email protected]>
@david-pace david-pace force-pushed the 18161-smoke-detector-alarm branch from a843afc to 5f7531c Compare January 28, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker will be requested when the pull request is marked ready for review GerdZanker is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[boschshc] Support for Smoke Alarm II channel Alarm
1 participant
@david-pace