Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce functionality to delete editor block #375

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat: introduce functionality to delete editor block #375

merged 1 commit into from
Jul 29, 2024

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Jul 26, 2024

Problem

We don't have the ability to delete blocks in the editor currently.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Features:

  • Introduce new functionality to delete both a complex and native block.
  • Added a new modal to confirm with the user that we want to delete the block.
  • Also fixed up the stick save button.

Screenshots

Screenshot 2024-07-26 at 15 22 39 Screenshot 2024-07-26 at 15 23 14

@dcshzj dcshzj requested a review from a team as a code owner July 26, 2024 07:23
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 7:25am

@seaerchin seaerchin merged commit 5c59d7d into main Jul 29, 2024
16 checks passed
@seaerchin seaerchin deleted the feat/delete-editor-block branch July 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @seaerchin