Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: numbering for nested ordered lists #349

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix: numbering for nested ordered lists #349

merged 2 commits into from
Jul 23, 2024

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Jul 23, 2024

Problem

The numbering for ordered lists keeps skipping by 1 whenever there is a nested list.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Bug Fixes:

  • Make the nested list be rendered properly (with ol, ul and p being siblings in a nested list).
    • No schema changes is necessary because that was the original intent of the schema (which also matches what Tiptap provides), just that the way it was used is incorrect.

Before & After Screenshots

BEFORE:

Screenshot 2024-07-23 at 16 48 35

AFTER:

Screenshot 2024-07-23 at 16 48 12

@dcshzj dcshzj requested a review from a team as a code owner July 23, 2024 08:49
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 9:06am

@dcshzj dcshzj merged commit 56ce8f6 into main Jul 23, 2024
15 of 16 checks passed
@dcshzj dcshzj deleted the fix/nested-lists-numbering branch July 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @seaerchin