ignore TrichromeLibrary since it doesn't extist for arm #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@root-intruder Do you happen to know if Google provides a Chrome/webview variant of arm that depends on trichrome, but has simply not been added to the OpenGapps repos yet? |
|
no I haven't researched much but according to #253 (comment) there should be...but since I don't want webview etc. in the rom I didn't further research |
|
There exists a TrichromeLibrary for arm and arm64. https://www.apkmirror.com/apk/google-inc/trichrome-library/trichrome-library-86-0-4240-110-release/ I guess this should be added to OpenGapps @mfonville |
|
@nezorflame and @NicholasBuse what is your take on this? |
|
While it does exist, it never worked for me when I was testing it. Need to take a second look at it though, maybe something changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to issue #222 I get build errors during makefile gathering for nonexisting packets on arm:
[ 99% 13085/13114] including vendor/opengapps/build/modules/TrichromeLibrary/Android.mk ... FAILED: zipinfo: cannot find or open , .zip or .ZIP. vendor/opengapps/build/modules/GoogleWebViewOverlay/Android.mk: error: TrichromeLibraryGoogle: No source files specified build/make/core/prebuilt_internal.mk:37: error: done. 10:28:56 ckati failed with: exit status 1...since TrichromeLibrary doesn't exist on arm only on arm64...thus it should be excluded from makefiles