Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force install the custom version of ipyleaflet #308

Closed
wants to merge 2 commits into from

Conversation

12rambau
Copy link
Member

As mentioned in openforis/sepal_ui#902, we cannot change the version of ipyleaflet used in sepal_ui to a branch. on the other hand it's perfectly possible to force intall it from here as we do for earthengine.

As long tas the applications are still using a loose pin on ipylaflet (which shoould be the case) it will work.

Mentioning @dfguerrerom for the follow-up

As mentioned in openforis/sepal_ui#902, we cannot change the version of ipyleaflet used in sepal_ui to a branch. on the other hand it's perfectly possible to force intall it from here as we do for earthengine. 

As long tas the applications are still using a loose pin on ipylaflet (which shoould be the case) it will work.

Mentioning @dfguerrerom for the follow-up
@dfguerrerom
Copy link
Contributor

@12rambau can you change your PR to jellyfish branch?

@12rambau 12rambau changed the base branch from master to jellyfish November 19, 2023 19:05
@12rambau
Copy link
Member Author

done

@dfguerrerom
Copy link
Contributor

dfguerrerom commented Nov 19, 2023

I would put this PR on hold until we decide tomorrow if it's better to use the wheel (too speed up the build) or the repo.

@12rambau: btw, I think the branch change has created some conflicts.

@dfguerrerom
Copy link
Contributor

no longer needed, check jupyter-widgets/ipyleaflet#1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants